Dataframe supports except and update readme #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
documentation
Member
|
@xudong963 looks like tests are failing |
Member
Author
Yes, after #1259 merging, I'll rebase this PR and the test will pass. |
This was referenced Nov 7, 2021
Member
Author
|
The ticket has been done! |
jimexist
reviewed
Nov 9, 2021
| task.await.expect("task completed successfully"); | ||
| } | ||
|
|
||
| #[tokio::test] |
Member
There was a problem hiding this comment.
do you want to add integration comparison test with psql as well?
Member
Author
There was a problem hiding this comment.
I am a little confused about if current test is enough. If we plan to add integration comparison test with psql, I want to know where to add and if there is an example.
houqp
approved these changes
Nov 9, 2021
Member
Author
|
Fix conflicts. |
houqp
approved these changes
Nov 10, 2021
Member
|
@jimexist could you take a final look? |
Member
|
we should be good to release 6.0 after this is merged. |
Member
Author
Member
|
thanks @xudong963 ! |
jimexist
pushed a commit
to jimexist/arrow-datafusion
that referenced
this pull request
Nov 13, 2021
matthewmturner
pushed a commit
to matthewmturner/arrow-datafusion
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1082
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?