Provide field and schema metadata missing on distinct aggregations. #12691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
Contributor
|
Thanks @jayzhan211 for the review and @wiedld for the fix I verified that the test fails without the code fix: 🐛 🥾 |
wiedld
added a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 2, 2024
…pache#12691) * test(12687): reproducer of missing metadata bug * fix(12687): minimum change needed to fix the missing metadata
wiedld
added a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 4, 2024
…pache#12691) * test(12687): reproducer of missing metadata bug * fix(12687): minimum change needed to fix the missing metadata
wiedld
added a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 9, 2024
…pache#12691) * test(12687): reproducer of missing metadata bug * fix(12687): minimum change needed to fix the missing metadata
wiedld
added a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 15, 2024
…pache#12691) * test(12687): reproducer of missing metadata bug * fix(12687): minimum change needed to fix the missing metadata
wiedld
added a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 16, 2024
…pache#12691) * test(12687): reproducer of missing metadata bug * fix(12687): minimum change needed to fix the missing metadata
Xuanwo
pushed a commit
to Xuanwo/datafusion
that referenced
this pull request
Oct 16, 2024
…pache#12691) * test(12687): reproducer of missing metadata bug * fix(12687): minimum change needed to fix the missing metadata
alamb
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 29, 2024
…pache#12691) * test(12687): reproducer of missing metadata bug * fix(12687): minimum change needed to fix the missing metadata
alamb
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Oct 31, 2024
…pache#12691) * test(12687): reproducer of missing metadata bug * fix(12687): minimum change needed to fix the missing metadata
alamb
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Nov 5, 2024
…pache#12691) * test(12687): reproducer of missing metadata bug * fix(12687): minimum change needed to fix the missing metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12687
Rationale for this change
A PR merged (and released in 42.0.0) has added a check that the logical and physical plan input schemas (to an aggregate node) are the same.
Once released into the wild, it began being triggered. One example case is issue #12687 where field metadata is in the logical plan, but missing from the physical plan.
What changes are included in this PR?
commit 1 = made regression tests, which are failing.
commit 2 = fixed those tests.
Are these changes tested?
Yes
Are there any user-facing changes?
No