Skip to content

Conversation

@findepi
Copy link
Member

@findepi findepi commented Oct 2, 2024

Setup rust toolchain build step was observed to be flaky. Retries may help.

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Oct 2, 2024
@findepi findepi force-pushed the findepi/retry-apt-get-and-rustup-on-ci-e9cd84 branch from 0b3514c to bc4f91b Compare October 2, 2024 10:27
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found here rust-lang/rustup#2869 that maybe --retry falg could help?

@findepi
Copy link
Member Author

findepi commented Oct 2, 2024

that seems to be available in rustup-init, the script downloaded from https://sh.rustup.rs that probably installs rustup
at least the rustup version i have locally doesn't support retries.

@findepi findepi force-pushed the findepi/retry-apt-get-and-rustup-on-ci-e9cd84 branch from bc4f91b to 9891a60 Compare October 2, 2024 16:41
@findepi findepi requested a review from comphead October 4, 2024 09:50
`Setup rust toolchain` build step was observed to be flaky. Retries may
help.
@findepi findepi force-pushed the findepi/retry-apt-get-and-rustup-on-ci-e9cd84 branch from 9891a60 to 4c289f4 Compare October 9, 2024 10:42
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retry for 10 seconds seems like a nice improvement to me. Thank you @findepi for trying to keep flakes down

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @findepi

@comphead comphead merged commit 8cf030a into apache:main Oct 9, 2024
@findepi findepi deleted the findepi/retry-apt-get-and-rustup-on-ci-e9cd84 branch October 26, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup rust toolchain build step is flaky

3 participants