Remove Expr clones in select_to_plan
#12887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
findepi
approved these changes
Oct 12, 2024
| /// They are returned in order of occurrence (depth | ||
| /// first), with duplicates omitted. | ||
| pub fn find_aggregate_exprs(exprs: &[Expr]) -> Vec<Expr> { | ||
| pub fn find_aggregate_exprs<'a>(exprs: impl IntoIterator<Item = &'a Expr>) -> Vec<Expr> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
In the call to
find_aggregate_exprs, we copied the select list expressions and the having expression.What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No
The public API
find_aggregate_exprsbecomes generalized and will not break existing calls.