Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jan 10, 2022

Rationale

As discussed with @realno on #1525 at #1525 (comment)
the distinction between Accumulator::updateandAccumulator::update_batch` was not 100% clear

Changes

Try to clarify the distinction using doc comments

@realno
Copy link
Contributor

realno commented Jan 10, 2022

Perhaps we can also add the same notes on merge_batch, I think it applies there too.

@houqp houqp added the documentation Improvements or additions to documentation label Jan 11, 2022
@alamb
Copy link
Contributor Author

alamb commented Jan 11, 2022

Perhaps we can also add the same notes on merge_batch, I think it applies there too.

Added in e37679f

@alamb alamb merged commit b42ebe7 into apache:master Jan 11, 2022
@alamb alamb deleted the alamb/update_comments branch August 8, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants