feat: Support quarter granularity in date_trunc function #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
commented
Jan 24, 2022
| } | ||
| } | ||
|
|
||
| fn quarter_month(date: &NaiveDateTime) -> u32 { |
alamb
approved these changes
Jan 24, 2022
liukun4515
approved these changes
Jan 25, 2022
Contributor
liukun4515
left a comment
liukun4515
left a comment
There was a problem hiding this comment.
LGTM
We can close #1381 if this pr is merged.
ovr
added a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Jan 31, 2022
ovr
added a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I saw PR #1381 from @PieterVanZyl-Dev , which was marked as stale PR, but I want to finish it.
What changes are included in this PR?
Support for quarter granularity in
date_truncfunction.Are there any user-facing changes?