Use NamedTempFile rather than String in DiskManager
#1680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @yjshen |
alamb
commented
Jan 25, 2022
| path.push(file_name); | ||
| path.to_str().unwrap().to_string() | ||
| } | ||
| fn create_tmp_file(local_dirs: &[TempDir]) -> Result<NamedTempFile> { |
Contributor
Author
There was a problem hiding this comment.
tempfiles are now generated using tempfile rather than string manipulation
alamb
commented
Jan 25, 2022
|
|
||
| fn read_spill_as_stream( | ||
| path: String, | ||
| path: NamedTempFile, |
Contributor
Author
There was a problem hiding this comment.
Since ownership of NamedTempFile is passed into the actual task doing the reading, when it is done, the temp file is cleaned up 🧹
houqp
approved these changes
Jan 26, 2022
yjshen
approved these changes
Jan 26, 2022
liukun4515
approved these changes
Jan 26, 2022
Contributor
liukun4515
left a comment
liukun4515
left a comment
There was a problem hiding this comment.
nice work and great explanation
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1679
Rationale for this change
Stringfor temporary files leaves the files around longer than necessary, and would cause trouble with a long lived DiskManager across plans.tempfilecrate in rust is likely to work better across operating systems than DataFusion specific tempfile creation logicWhat changes are included in this PR?
DiskManagerpasses outNamedTempFiles rather thanString(when these are dropped they also clean up the temp file immediately)Are there any user-facing changes?
No