Skip to content

minor: Include consumer name in OOM message #17870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2025
Merged

minor: Include consumer name in OOM message #17870

merged 3 commits into from
Oct 2, 2025

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Oct 1, 2025 •
edited
Loading

Which issue does this PR close?

N/A

Rationale for this change

I am debugging OOM issues with DataFusion Comet and find it useful to know which consumer/reservation is failing to grow its reservation.

Before:

Additional allocation failed with top memory consumers (across reservations) as:

After:

Additional allocation failed for ExternalSorterMerge[53] with top memory consumers (across reservations) as:

What changes are included in this PR?

Improve the exception message to include the consumer name.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the execution Related to the execution crate label Oct 1, 2025
@andygrove andygrove mentioned this pull request Oct 1, 2025
Closed
@andygrove andygrove marked this pull request as draft October 1, 2025 21:07
@andygrove andygrove changed the title minor: Include consumer name in OOM message minor: Include consumer name in OOM message [WIP] Oct 1, 2025
@github-actions github-actions bot added the core Core DataFusion crate label Oct 1, 2025
@github-actions github-actions bot added the physical-plan Changes to the physical-plan crate label Oct 1, 2025
@andygrove andygrove changed the title minor: Include consumer name in OOM message [WIP] minor: Include consumer name in OOM message Oct 1, 2025
@andygrove andygrove requested a review from alamb October 1, 2025 23:07
@andygrove andygrove marked this pull request as ready for review October 1, 2025 23:07
parthchandra
parthchandra approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

2010YOUY01
2010YOUY01 approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@2010YOUY01 2010YOUY01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@xudong963 xudong963 added this pull request to the merge queue Oct 2, 2025
Merged via the queue into apache:main with commit a9d0460 Oct 2, 2025
29 checks passed
@andygrove andygrove deleted the oom-consumer-name branch October 2, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthchandra parthchandra parthchandra approved these changes

@2010YOUY01 2010YOUY01 2010YOUY01 approved these changes

@xudong963 xudong963 xudong963 approved these changes

@alamb alamb Awaiting requested review from alamb

@comphead comphead Awaiting requested review from comphead

@mbutrovich mbutrovich Awaiting requested review from mbutrovich

Assignees

No one assigned

Labels

core Core DataFusion crate execution Related to the execution crate physical-plan Changes to the physical-plan crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andygrove @parthchandra @2010YOUY01 @xudong963