fix: Add overflow checks to SparkDateAdd/Sub to avoid panics #18013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Oct 10, 2025
| query D | ||
| SELECT date_sub('2016-07-30'::date, 2147483647::int); | ||
| ---- | ||
| ERROR: Cast error: Failed to convert -2147466635 to temporal for Date32 |
There was a problem hiding this comment.
ERROR: Cast error: Failed to convert -2147466635 to temporal for Date32 is it a result returned by date_sub 🤔 ?
There was a problem hiding this comment.
No. This error is unrelated to the changes in this PR, but I thought it was good to add the test.
I was expecting to see an overflow though. I will try and track down the root cause.
There was a problem hiding this comment.
I added a test to show negative overflow
parthchandra
approved these changes
Oct 10, 2025
|
🚀 |
25 tasks
hareshkh
pushed a commit
to hareshkh/datafusion
that referenced
this pull request
Oct 17, 2025
…18013) * fix * fix * fix * fix * fix * add negative overflow test * remove unrelated test * update test
|
FYI @andygrove - created a PR to cherry-pick this to branch-50 : #18131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DateAdd/DateSubdo not perform overflow checks in release builds datafusion-comet#2539Rationale for this change
Return errors rather than panicking.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?