Skip to content

fix: null cast not valid in substrait round trip #18414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 3, 2025
Merged

fix: null cast not valid in substrait round trip #18414

merged 5 commits into from
Nov 3, 2025
+30 −7

Conversation

@gene-bordegaray
Copy link
Contributor

@gene-bordegaray gene-bordegaray commented Oct 31, 2025 •
edited
Loading

Which issue does this PR close?

Rationale for this change

  • Null with null type were throwing invalid casts in substrait round trips

What changes are included in this PR?

  • Added a null variation const that allows NULL with NULL types to be casted properly.
  • Made this a UserDefined type from the substrait side of things

Are these changes tested?

  • Yes added unit test in producer/types.rs
  • Previously failing tests pass

Are there any user-facing changes?

@github-actions github-actions bot added the substrait Changes to the substrait crate label Oct 31, 2025
@gene-bordegaray gene-bordegaray marked this pull request as draft October 31, 2025 19:41
@gene-bordegaray gene-bordegaray marked this pull request as ready for review October 31, 2025 20:40
gabotechs
gabotechs approved these changes Nov 1, 2025
View reviewed changes
Copy link
Contributor

@gabotechs gabotechs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! nothing to add, this just looks like what we need.

Thanks @gene-bordegaray!

@gene-bordegaray gene-bordegaray changed the title Gene.bordegaray/2025/10/fix null cast not valid in substrait round trip fix: null cast not valid in substrait round trip Nov 1, 2025
@gabotechs gabotechs added this pull request to the merge queue Nov 3, 2025
Merged via the queue into apache:main with commit 720d4f1 Nov 3, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabotechs gabotechs gabotechs approved these changes

Assignees

No one assigned

Labels

substrait Changes to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[substrait] [sqllogictest] Null cast is not valid

2 participants

@gene-bordegaray @gabotechs