feat: deprecate AggregateUDF: :is_nullable #18934
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Jefffrey
approved these changes
Nov 26, 2025
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Surprisingly fewer changes than I expected
codetyri0n
force-pushed
the
deprecate_is_nullable
branch
from
7f99f29 to
810cae5
Compare
martin-g
reviewed
Nov 26, 2025
Member
martin-g
left a comment
martin-g
left a comment
There was a problem hiding this comment.
- https://github.com/codetyri0n/datafusion/blob/810cae5c0471a4050e2a9b4ac8580eaf5f039906/datafusion/ffi/src/udaf/mod.rs#L347 is not annotated with
#[expect(deprecated)] - https://github.com/codetyri0n/datafusion/blob/810cae5c0471a4050e2a9b4ac8580eaf5f039906/datafusion/functions-aggregate/src/count.rs#L299 - should something be done for overrides like this one ?
| self.inner.window_function_display_name(params) | ||
| } | ||
|
|
||
| pub fn is_nullable(&self) -> bool { |
Member
There was a problem hiding this comment.
Should this method be deprecated too ?
Contributor
Author
thanks for catching the mod.rs miss @martin-g , i had left the count.rs file untouched as i dont see the signature or the implementation getting altered much in the near future |
codetyri0n
force-pushed
the
deprecate_is_nullable
branch
from
810cae5 to
2aeedc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
AggregateUDFImpl::is_nullablein favour ofreturn_field#18882Rationale for this change
Are these changes tested?
Are there any user-facing changes?