Enable clippy::allow_attributes lint for datafusion-catalog #18973
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
Jefffrey
approved these changes
Nov 28, 2025
datafusion/catalog/src/lib.rs
Outdated
| #![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))] | ||
| #![deny(clippy::needless_pass_by_value)] | ||
| #![cfg_attr(test, allow(clippy::needless_pass_by_value))] | ||
| #![warn(clippy::allow_attributes)] |
Contributor
There was a problem hiding this comment.
Should this be a deny like we do for needless_pass_by_value above?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, I've updated the lint level to deny .
Contributor
|
Thanks @chakkk309 |
chakkk309
deleted the
Enable-clippyallow_attributes-lint-for-datafusion-catalog-
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
clippy::allow_attributes#18881Rationale for this change
Replace #[allow] with #[expect] to enable automatic detection when lint suppressions are no longer needed.
What changes are included in this PR?
Replace 4 #[allow] attributes with #[expect] in datafusion-catalog
Are these changes tested?
yes
Are there any user-facing changes?
No user-facing changes.