chore: merge make_array and spark array #19006
Merged
+30
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
xudong963
approved these changes
Dec 1, 2025
Jefffrey
approved these changes
Dec 2, 2025
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
I think this is a step in the right direction for removing some duplication; can look into further refactorings later
| Volatility::Immutable, | ||
| ), | ||
| aliases: vec![String::from("spark_make_array")], | ||
| aliases: vec![], |
Contributor
There was a problem hiding this comment.
We can remove the aliases field entirely
Contributor
|
Thanks @jizezhang & @xudong963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #17964.
Rationale for this change
What changes are included in this PR?
arrayfunction when data type is null to be consistent with that returned in Spark.make_arrayand sparkarray.Are these changes tested?
Yes
Are there any user-facing changes?
No