Add upgrade guide for PhysicalOptimizerRule::optimize_plan #19030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
This was referenced Dec 1, 2025
milenkovicm
reviewed
Dec 1, 2025
| - Session extensions via `context.session_config().extensions()` | ||
|
|
||
| This enables optimizer rules to access custom extensions registered with the session, which was not possible with the old `&ConfigOptions` parameter. | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe change to extension should be mentioned as well?
Contributor
Author
There was a problem hiding this comment.
I think we just made something that was private public - is that really worth mentioning?
Contributor
There was a problem hiding this comment.
You’re right, the previous methods remain unchanged so from the user’s perspective nothing changes. My apologies.
xudong963
reviewed
Dec 2, 2025
|
|
||
| **Who is affected:** | ||
|
|
||
| - Users who have implemented custom `PhysicalOptimizerRule` implementations |
Member
There was a problem hiding this comment.
cc @zhuqi-lucas / @jcsherin , we need to make some changes for the next upgrade
Contributor
Author
There was a problem hiding this comment.
Sorry about this! At least it should be pretty mechanical and you'll have several releases...
xudong963
approved these changes
Dec 2, 2025
zhuqi-lucas
approved these changes
Dec 2, 2025
Co-authored-by: Yongting You <2010youy01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19029