fix: spark sha1 nullability reporting #19242
Open
+54
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the nullability reporting for the Spark sha1 UDF to correctly propagate nullability from input arguments and null scalar values, aligning with Spark semantics.
Key changes:
- Implemented
return_field_from_argsmethod to compute output nullability based on input field nullability and null scalar arguments - Modified
return_typeto return an error directing callers to usereturn_field_from_argsinstead - Added comprehensive unit tests for nullability behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ShashidharM0118
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
sha1need to have custom nullability #19158Rationale for this change
The Spark
sha1UDF was always marked nullable because it relied on the default nullability; Spark semantics require the output nullability to follow the input (or null scalar) instead.What changes are included in this PR?
return_field_from_argsforSparkSha1to reportUtf8with nullability derived from argument fields or null scalar args, and guardreturn_type.Are these changes tested?
Yes,
Are there any user-facing changes?
No behavior change beyond correct nullability reporting for
sha1results.