Skip to content

[branch 52] Fix grouping set subset satisfaction #19855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gabotechs merged 1 commit into from
Jan 16, 2026
Merged

[branch 52] Fix grouping set subset satisfaction #19855

gabotechs merged 1 commit into from
Jan 16, 2026
+263 −2

Conversation

@gabotechs
Copy link
Contributor

@gabotechs gabotechs commented Jan 16, 2026 •
edited by alamb
Loading

@freakyzoidberg @gabotechs
Fix grouping set subset satisfaction (apache#19853)
6caf352 
## Summary
- Fixes incorrect results from ROLLUP/CUBE/GROUPING SETS queries when
using multiple partitions
- The subset satisfaction optimization was incorrectly allowing hash
partitioning on fewer columns to satisfy requirements that include
`__grouping_id`
- This caused partial aggregates from different partitions to be
finalized independently, producing duplicate grand totals
  
Closes apache#19849
@gabotechs gabotechs changed the base branch from main to branch-52 January 16, 2026 16:08
@gabotechs gabotechs mentioned this pull request Jan 16, 2026
Open
15 tasks
alamb
alamb approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gabotechs

@gabotechs gabotechs merged commit eb00fe2 into apache:branch-52 Jan 16, 2026
1 of 2 checks passed
@gabotechs gabotechs deleted the branch-52 branch January 16, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabotechs @alamb @freakyzoidberg