Skip to content

perf: Optimize scalar path for ascii function #19951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kumarUjjawal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: Optimize scalar path for ascii function #19951

kumarUjjawal wants to merge 1 commit into from
+57 −4

Conversation

@kumarUjjawal
Copy link
Contributor

@kumarUjjawal kumarUjjawal commented Jan 23, 2026

Which issue does this PR close?

Rationale for this change

The ascii function currently converts scalar inputs to arrays before processing via make_scalar_function. Adding a scalar fast path avoids this overhead and improves performance.

What changes are included in this PR?

  1. Refactored invoke_with_args to use match statement for handling both scalar and array inputs
  2. Added scalar fast path for Utf8, LargeUtf8, and Utf8View scalar inputs
Type Before After Speedup
ascii/scalar_utf8 234 ns 56 ns 4.2x
ascii/scalar_utf8view 206 ns 57 ns 3.6x

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the functions Changes to functions implementation label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

functions Changes to functions implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kumarUjjawal