perf: improve performance of array_remove, array_remove_n and array_remove_all functions
#19996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The current implementation of
general_removeis based onfilter + concat, which creates intermediate arrays for each list row and can be relatively expensive.This PR introduces an alternative implementation based on
MutableArrayData, which copies contiguous ranges from the original values buffer directly into the output array. The new approach is semantically equivalent to the existing implementation but reduces intermediate allocations and per-element overhead.What changes are included in this PR?
general_remove's filter-based implementation withMutableArrayDatafor more efficient memory usage.Benchmark
Are these changes tested?
Yes. Existing SLT for
arraycontinue to pass without modification. Benchmarks were added.Are there any user-facing changes?
No.