refactor: make PhysicalExprAdatperFactory::create fallible #20017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niebayes
force-pushed
the
refactor/fallible_create
branch
from
2e51003 to
aeab757
Compare
github-actions
bot
added
core
adriangb
approved these changes
Jan 27, 2026
Contributor
adriangb
left a comment
adriangb
left a comment
There was a problem hiding this comment.
This looks good to me. Really no changes outside of examples and tests. Let’s leave open for a couple days to allow other feedback.
xudong963
approved these changes
Jan 27, 2026
Contributor
|
Btw I don't think an entry in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes, covered by existing unit tests.
Are there any user-facing changes?
PhysicalExprAdapterFactory::createnow returns a result and I think this is a breaking change.