Tweak adapter serialization example
#20035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove inner_plan_bytes from ExtensionPayload - Store inner plan as protobuf child in extension.inputs instead of encoded bytes - Update serialization to include inner_proto in inputs field - Update deserialization to access child from extension.inputs[0] - Simplify try_decode to use pre-deserialized children from inputs - Remove unused prost::Message import This implements the wrapper node pattern where metadata is separated from structure, leveraging the framework's recursive serialization/deserialization. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
timsaucer
approved these changes
Jan 27, 2026
Member
|
CI failure looks unrelated. |
Contributor
Author
Yep I will rerun though once CI passes just to make sure we don't break main... twice. Assuming it passes then I'll merge. Ty for the quick review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #19437
The main changes made here are:
The end result is a slightly smaller line count and I think slightly better approach.