-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Qualified wildcard #2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualified wildcard #2012
Changes from all commits
fffe9a0
1b23fce
1cf9093
e4daa93
80d0483
20607cc
65dd939
48f0eee
706d97d
26c6b91
a5659eb
b9a9538
a2dc969
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -228,6 +228,8 @@ pub enum Expr { | |
| }, | ||
| /// Represents a reference to all fields in a schema. | ||
| Wildcard, | ||
| /// Represents a reference to all fields in a specific schema. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I personally have a slight preference for a single Wildcard { qualifier: Option<String>}but that is a personal preference and there is nothing wrong with this approach |
||
| QualifiedWildcard { qualifier: String }, | ||
| } | ||
|
|
||
| /// Fixed seed for the hashing so that Ords are consistent across runs | ||
|
|
@@ -512,6 +514,7 @@ impl fmt::Debug for Expr { | |
| } | ||
| } | ||
| Expr::Wildcard => write!(f, "*"), | ||
| Expr::QualifiedWildcard { qualifier } => write!(f, "{}.*", qualifier), | ||
| Expr::GetIndexedField { ref expr, key } => { | ||
| write!(f, "({:?})[{}]", expr, key) | ||
| } | ||
|
|
@@ -696,6 +699,9 @@ fn create_name(e: &Expr, input_schema: &DFSchema) -> Result<String> { | |
| Expr::Wildcard => Err(DataFusionError::Internal( | ||
| "Create name does not support wildcard".to_string(), | ||
| )), | ||
| Expr::QualifiedWildcard { .. } => Err(DataFusionError::Internal( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we can create a name for
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree including the name of the qualifier in the message might be helpful |
||
| "Create name does not support qualified wildcard".to_string(), | ||
| )), | ||
| } | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -206,6 +206,9 @@ fn create_physical_name(e: &Expr, is_first_expr: bool) -> Result<String> { | |
| Expr::Wildcard => Err(DataFusionError::Internal( | ||
| "Create physical name does not support wildcard".to_string(), | ||
| )), | ||
| Expr::QualifiedWildcard { .. } => Err(DataFusionError::Internal( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
| "Create physical name does not support qualified wildcard".to_string(), | ||
| )), | ||
| } | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.