Skip to content

fix: Avoid assertion failure on divide-by-zero #20216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Feb 8, 2026
+10 −1
Merged

fix: Avoid assertion failure on divide-by-zero #20216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/physical-expr/src/analysis.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ pub fn analyze(
"ExprBoundaries has a non-zero distinct count although it represents an empty table"
);
assert_or_internal_err!(
context.selectivity == Some(0.0),
context.selectivity.unwrap_or(0.0) == 0.0,
"AnalysisContext has a non-zero selectivity although it represents an empty table"
);
Ok(context)
Expand Down
9 changes: 9 additions & 0 deletions datafusion/sqllogictest/test_files/select.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1926,3 +1926,12 @@ select "current_time" is not null from t_with_current_time;
true
false
true

# https://github.com/apache/datafusion/issues/20215
statement count 0
CREATE TABLE t0;

query I
SELECT COUNT(*) FROM t0 AS tt0 WHERE (4==(3/0));
----
0