Add Expr::Alias passthrough to Expr::placement() #20237
Merged
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Feb 9, 2026
alamb
reviewed
Feb 9, 2026
| 02)--Projection: get_field(simple_struct.s, Utf8("value")) AS __common_expr_1 | ||
| 03)----Filter: simple_struct.id > Int64(2) | ||
| 04)------TableScan: simple_struct projection=[id, s], partial_filters=[simple_struct.id > Int64(2)] | ||
| 01)Projection: get_field(simple_struct.s, Utf8("value")) + get_field(simple_struct.s, Utf8("value")) AS doubled |
Contributor
There was a problem hiding this comment.
this looks like a nicer plan to me (one less level of Projection)
Contributor
Author
There was a problem hiding this comment.
yep the intuition is that there's no point in de-duplicating get_field because it's so trivial to compute
Contributor
Author
|
Thanks @alamb will merge once CI finishes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling out of #20117.
Aliases cause no compute or changes to how compute happens. They should delegate to their inner expression.