chore: Cleanup returning null arrays#20423
Merged
comphead merged 2 commits intoapache:mainfrom Feb 19, 2026
Merged
Conversation
Cleanup a few places where the code returned a null array but it would be a bit cleaner and faster to return a typed scalar null instead.
Contributor
Author
|
cc @Jefffrey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup a few places where the code returned a null array but it would be a bit cleaner and faster to return a typed scalar null instead.
Which issue does this PR close?
Does not close an issue; this cleanup was mentioned in the code review for #20361
Rationale for this change
Returning a typed scalar null should be preferred to returning a null array: it still has type information, and avoids materializing an all-null array. The downstream consumer can always materialize the equivalent array if they want to.
What changes are included in this PR?
Cleanup five instances of this pattern.
Are these changes tested?
Yes. No new test cases possible/warranted.
Are there any user-facing changes?
No.