feat: multiple columns in count distinct#20460
Open
Mark1626 wants to merge 3 commits intoapache:mainfrom
Open
Conversation
Dandandan
reviewed
Feb 21, 2026
|
|
||
| #[derive(Debug)] | ||
| struct MultiColumnDistinctCountAccumulator { | ||
| values: HashSet<Vec<ScalarValue>, RandomState>, |
Contributor
There was a problem hiding this comment.
Probably https://docs.rs/arrow-row/latest/arrow_row/struct.Row.html or some custom hashing/equality would be much faster than Vec<ScalarValue> as key.
comphead
reviewed
Feb 21, 2026
| Ok(()) | ||
| } | ||
|
|
||
| #[tokio::test] |
Contributor
There was a problem hiding this comment.
please have tests in .slt
comphead
reviewed
Feb 21, 2026
Contributor
There was a problem hiding this comment.
Thanks @Mark1626 for driving this 💪
Before going to code review lets expand tests a little bit to support possible cases, specifically:
- mixed nulls in values
- different column datatypes
- 3+ cols
- different col order
- duplicates like
select count(distinct a, a), select count(distinct a, a, b, b)`
Once we have tests passed, we most likely got the code is stable and ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5619
What changes are included in this PR?
MultiColumnDistinctCountAccumulatorAre these changes tested?