Merged
Conversation
Dandandan
commented
Feb 21, 2026
| // sort the files first. | ||
| // https://github.com/apache/datafusion/pull/6629 | ||
| schemas.sort_by(|(location1, _), (location2, _)| location1.cmp(location2)); | ||
| schemas |
Contributor
Author
There was a problem hiding this comment.
Remove allocation during sort
Dandandan
commented
Feb 21, 2026
| .into_iter() | ||
| .map(|(_, schema)| schema) | ||
| .collect::<Vec<_>>(); | ||
| let schemas = schemas.into_iter().map(|(_, schema)| schema); |
Contributor
Author
There was a problem hiding this comment.
Remove one more allocation
comphead
approved these changes
Feb 21, 2026
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @Dandandan if I understood correctly the order doesn't matter in modified scenarios?
jayzhan211
approved these changes
Feb 22, 2026
Contributor
Author
The order doesn't matter as it is sorted afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
buffer_unorderedshould be slightly better here - as we sort by the paths anyway (perhaps we can reduce the default concurrency).Also remove some unnecessary allocations.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?