-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: SortMergeJoin don't wait for all input before emitting #20482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+562
−34
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ba87c51
fix: SortMergeJoin don't wait for all input before creating emitting
rluvaton d028236
fix build
rluvaton 8104d55
add reproducing tests for all join types and with + without filter
rluvaton 814afab
format and lint
rluvaton 4ca5ea3
add error
rluvaton bec4f21
fix test
rluvaton 86d0578
format and lint
rluvaton 0a5cd16
comment
rluvaton 7af653b
assert with expected output
rluvaton 6bc1e0b
fix test and log
rluvaton 93be13f
remove todo
rluvaton 869264e
format and lint
rluvaton 3205c1a
use correct batch size in tests
rluvaton d87058d
reuse schema and changed to emit ready than init state
rluvaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a point in not doing a let Some() on next_completed_batch()?
afaict it's a simple pop and has_completed_batch() just checks that the queue isn't empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next refactor I have already