perf: Optimize array_position for scalar needle#20532
Open
neilconway wants to merge 2 commits intoapache:mainfrom
Open
perf: Optimize array_position for scalar needle#20532neilconway wants to merge 2 commits intoapache:mainfrom
array_position for scalar needle#20532neilconway wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Benchmarks:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_positionwith scalar needle #20530Rationale for this change
The previous implementation of
array_positionusedcompare_element_to_listfor every input row. When the needle is a scalar (quite common), we can do much better by searching over the entire flat haystack values array with a single call toarrow_ord::cmp::not_distinct. We can then iterate over the resulting set bits to determine per-row results.This is ~5-10x faster than the previous implementation for typical inputs.
What changes are included in this PR?
array_positionwith scalar needlearray_positioninternal_errto report a user-visible errorAre these changes tested?
Yes, and benchmarked. Additional tests added in a separate PR (#20531)
Are there any user-facing changes?
No.