Fix FileStream scanning_total to include sync next-file open time#20627
Open
RatulDawar wants to merge 1 commit intoapache:mainfrom
Open
Fix FileStream scanning_total to include sync next-file open time#20627RatulDawar wants to merge 1 commit intoapache:mainfrom
RatulDawar wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_next_file()/FileOpener::open()setup time intime_elapsed_scanning_totaltime_openingand scanning timers lifecycle intacttime_scanning_total.start()Details
In
FileStreamState::Open,start_next_file()is invoked beforetime_scanning_total.start(). Ifopen()performs synchronous work before returning the future, that time was previously unaccounted for intime_elapsed_scanning_total.This change wraps the
start_next_file()call in a scoped timer on the sametime_scanning_totalmetric so the missing segment is recorded.Fixes #20571
Validation
cargo test -p datafusion-datasource with_limit_at_middle_of_batch -- --nocapture