Conversation
AdamGS
left a comment
AdamGS
left a comment
There was a problem hiding this comment.
FWIW, we've also found mimalloc making a huge difference on macos, which I assume is a very popular dev environment
related to #20052 [Example run](https://github.com/apache/datafusion/actions/runs/22663392017/job/65688981067): 2X faster (50 min → 25 min)
github-actions
bot
added
the
development-process
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @blaginin however I'm not sure about mimalloc for tests tbh, we do mimalloc for benchmarks, but tests asserts correctness and mem usage for default user environment which is glibc malloc or musl malloc if we speaking for Linux and providing results from another mem allocator as a source of truth, WDYT?
|
hey @comphead! In this pr i change just sqlogictests, and they don't assert mem usage - just correctness. They're pretty high level so I'd be surprised if the allocator interferes in any way |
IMO I would still expect tests to be in the same environment, otherwise it would be a debugging nightmare in case of false positives or false negatives 🤔 |
3 participants
related to #20052
https://github.com/apache/datafusion/actions/runs/22638279915/job/65619265884
-5-10 minutes