[branch-52] fix: HashJoin panic with String dictionary keys (don't flatten keys) (#20505)#20708
Merged
alamb merged 2 commits intoapache:branch-52from Mar 5, 2026
Merged
Conversation
apache#20505) - Fixes apache#20696 - Follow on to apache#20441 apache#20441 (review) fixes the special case DictionaryArray handling in Joins. However, I don't think we need to special case DictionaryArrays at all 1. Remove the special case dictionary handling Yes by CI No (though maybe some queries get faster)
github-actions
bot
added
sqllogictest
adriangb
approved these changes
Mar 4, 2026
12 tasks
Contributor
Author
|
The tests are failing due to the lack of a fix for #20041 I made a separate backport PR for that here I verified that with the change in the tests in this PR also pass |
Contributor
Author
|
Ok -- everything is good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INNER JOINwith dictionary keys fails when run on parquet withpushdown_filters = true. #20696 on branch-52This PR:
HashJoinpanic with String dictionary keys (don't flatten keys) #20505 from to the [branch-52] line