Improve documentation for AggregateUdfImpl::simplify and WindowUDFImpl::simplify#20712
Merged
comphead merged 2 commits intoapache:mainfrom Mar 5, 2026
Merged
Improve documentation for AggregateUdfImpl::simplify and WindowUDFImpl::simplify#20712comphead merged 2 commits intoapache:mainfrom
AggregateUdfImpl::simplify and WindowUDFImpl::simplify#20712comphead merged 2 commits intoapache:mainfrom
Conversation
alamb
force-pushed
the
alamb/better_simplity_docs
branch
from
50f2d88 to
1626cf7
Compare
alamb
changed the title
AggregateUdfImpl::simplifyAggregateUdfImpl::simplify and WindowUDFImpl::simplify
2010YOUY01
approved these changes
Mar 5, 2026
Contributor
2010YOUY01
left a comment
2010YOUY01
left a comment
There was a problem hiding this comment.
Thank you, great doc improvement 👍🏼
4 tasks
Co-authored-by: Yongting You <2010youy01@gmail.com>
github-actions
bot
removed
the
documentation
Contributor
Author
|
Thanks @2010YOUY01 and @comphead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While working on #20665 I was somewhat confused about how the AggregateUDF simplify worked. So I added some more clarifying comments
What changes are included in this PR?
Are these changes tested?
Yes by CI
Are there any user-facing changes?
Better API docs