perf: optimize map validation for common key types#20805
Open
lyne7-sc wants to merge 5 commits intoapache:mainfrom
Open
perf: optimize map validation for common key types#20805lyne7-sc wants to merge 5 commits intoapache:mainfrom
lyne7-sc wants to merge 5 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Benchmarks: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR optimizes
mapkey validation for common key types.Previously,
mapvalidation always used the genericScalarValue::try_from_arraypath, which is more expensive than necessary for common key types such as primitive integers, strings, and binary values.What changes are included in this PR?
mapkey validation for primitive, string, and binary key typesAre these changes tested?
Yes. current unit tests and slts test passed. benchmark added.
Are there any user-facing changes?
No.