Skip to content

refactor: Improve SessionContext::parse_duration API#20816

Open
erenavsarogullari wants to merge 1 commit intoapache:mainfrom
erenavsarogullari:improve_parse_duration_api
Open

refactor: Improve SessionContext::parse_duration API#20816
erenavsarogullari wants to merge 1 commit intoapache:mainfrom
erenavsarogullari:improve_parse_duration_api

Conversation

@erenavsarogullari
Copy link
Member

@erenavsarogullari erenavsarogullari commented Mar 9, 2026

Which issue does this PR close?

Rationale for this change

This is follow-up PR for #20371.

Similarly to SessionContext::parse_capacity_limit API, SessionContext::parse_duration API also needs to have following improvements:

  1. Validation for empty or blank duration values:
SET datafusion.runtime.list_files_cache_ttl = ' '

Current:
DataFusion error: Error during planning: Failed to parse number from duration ' '

New:
DataFusion error: Error during planning: Duration should not be empty or blank for 'datafusion.runtime.list_files_cache_ttl'

  1. Exposing config name in error messages,
  2. Comprehensive test coverage for invalid durations,
  3. Updating datafusion.runtime.list_files_cache_ttl documentation for other allowed settings.

What changes are included in this PR?

Explained in the first section.

Are these changes tested?

Yes, being extended existing test cases.

Are there any user-facing changes?

Yes, config name has been added to error message when the validation is failed.

@github-actions github-actions bot added documentation Improvements or additions to documentation core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Mar 9, 2026
@erenavsarogullari erenavsarogullari force-pushed the improve_parse_duration_api branch 2 times, most recently from cf9d0e9 to a11c3c6 Compare March 9, 2026 04:27
@erenavsarogullari erenavsarogullari force-pushed the improve_parse_duration_api branch from a11c3c6 to 9663db3 Compare March 9, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate documentation Improvements or additions to documentation sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve SessionContext::parse_duration API

1 participant