Add optimizer-focused benchmarks for logical plan optimization#20834
Draft
adriangb wants to merge 1 commit intoapache:mainfrom
Draft
Add optimizer-focused benchmarks for logical plan optimization#20834adriangb wants to merge 1 commit intoapache:mainfrom
adriangb wants to merge 1 commit intoapache:mainfrom
Conversation
Add 17 new benchmarks to sql_planner.rs that stress the logical optimizer across different dimensions: deep join chains (4/8/16 tables), wide expressions (50-200 filter predicates, 100 aggregates, 50 CASE exprs), mixed deep+wide plans, correlated subqueries, unions, distinct, and nested CTEs. Also uncomment TPC-H and TPC-DS full-suite benchmarks. These benchmarks help identify optimizer bottlenecks as plan complexity grows, complementing the existing simple-plan benchmarks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sql_planner.rsthat stress the logical optimizer across different dimensions:These complement the existing simple-plan benchmarks (2-6 node plans) by covering the optimizer's behavior as plan complexity grows — useful for tracking optimizer performance improvements (ref #15045).
Test plan
cargo bench --bench sql_plannerruns successfully with all new benchmarkssql_planner_extended.rsoroptimizer/benches/🤖 Generated with Claude Code