minor: Move PreparedAccessPlan to same module as ParquetAccessPlan#20929
Merged
Dandandan merged 1 commit intoapache:mainfrom Mar 14, 2026
Merged
minor: Move PreparedAccessPlan to same module as ParquetAccessPlan#20929Dandandan merged 1 commit intoapache:mainfrom
Dandandan merged 1 commit intoapache:mainfrom
Conversation
alamb
force-pushed
the
alamb/consolidate_prepared_plan
branch
from
9e03577 to
105131b
Compare
Contributor
Author
|
Hi @zhuqi-lucas -- I wonder if you are interested in reviewing this PR |
zhuqi-lucas
approved these changes
Mar 14, 2026
Contributor
zhuqi-lucas
left a comment
zhuqi-lucas
left a comment
There was a problem hiding this comment.
LGTM, thanks @alamb !
Dandandan
reviewed
Mar 14, 2026
| } | ||
|
|
||
| /// Prepare this plan and resolve to the final `PreparedAccessPlan` | ||
| pub(crate) fn prepare( |
Dandandan
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While working on morselization, I found that the
PreparedAccessPlanwas in a different module which made it harder to understand the relationship between the two. Thus, I think it would be better to move PreparedAccessPlan to the same module as ParquetAccessPlan.What changes are included in this PR?
Are these changes tested?
Yes by CI
Are there any user-facing changes?
No