fix: update clickbench expected plan for NDV-aware optimization#21050
Merged
timsaucer merged 1 commit intoapache:mainfrom Mar 19, 2026
Merged
fix: update clickbench expected plan for NDV-aware optimization#21050timsaucer merged 1 commit intoapache:mainfrom
timsaucer merged 1 commit intoapache:mainfrom
Conversation
apache#19957 introduced NDV extraction from Parquet metadata. The optimizer now sees NDV=1 for HitColor, BrowserCountry, BrowserLanguage in the clickbench test file and short-circuits COUNT(DISTINCT) to a constant projection, skipping the full table scan.
Member
Author
|
(cc: @timsaucer as you reported the problem in CI and you have rights to merge the PR if it looks OK to you, tested locally but I might have missed something, waiting for CI) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes CI breakage on
mainintroduced by #19957.Rationale for this change
#19957 introduced NDV extraction from Parquet metadata. The optimizer now sees NDV=1 for
HitColor,BrowserCountry,BrowserLanguagein the clickbench test file and short-circuitsCOUNT(DISTINCT)to a constant projection, skipping the full table scan.What changes are included in this PR?
Updates the expected EXPLAIN plan in
clickbench.sltto match the new (better) physical plan:Are these changes tested?
This PR is the test fix. Verified locally with
cargo test --profile ci -p datafusion-sqllogictest --test sqllogictests.Are there any user-facing changes?
No.