add proto converter reference to PhysicalExtensionCodec#21055
Draft
jayshrivastava wants to merge 1 commit intoapache:mainfrom
Draft
add proto converter reference to PhysicalExtensionCodec#21055jayshrivastava wants to merge 1 commit intoapache:mainfrom
jayshrivastava wants to merge 1 commit intoapache:mainfrom
Conversation
…mic filter deduping to work in custom plan nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PhysicalProtoConverterExtensiontoPhysicalExtensionCodec#21056Rationale for this change
Custom
ExecutionPlannodes that storePhysicalExprfields cannot participate in expression deduplication during serialization becausePhysicalExtensionCodec::try_encode/try_decodelack access to thePhysicalProtoConverterExtension.What changes are included in this PR?
proto_converter: &dyn PhysicalProtoConverterExtensionparameterto
PhysicalExtensionCodec::try_decodeandtry_encodeDefaultPhysicalExtensionCodec,ComposedPhysicalExtensionCodec,ForeignPhysicalExtensionCodec(FFI),and all examples
PhysicalPlanNodeserialization/deserializationDefaultPhysicalProtoConverteras a fallbackAre these changes tested?
Yes — added
test_custom_node_with_dynamic_filter_dedup_roundtripwhichverifies that a
DynamicFilterPhysicalExprshared between aFilterExecand a custom
ExecutionPlannode preserves its shared inner state after aroundtrip through
DeduplicatingProtoConverter.Are there any user-facing changes?
Breaking API change:
PhysicalExtensionCodec::try_decodeandtry_encodenow take an additional
&dyn PhysicalProtoConverterExtensionparameter.All custom codec implementations must be updated.