Fix Unparser for stacked Projections & Expand Unparser tests#21067
Open
cetra3 wants to merge 1 commit intoapache:mainfrom
Open
Fix Unparser for stacked Projections & Expand Unparser tests#21067cetra3 wants to merge 1 commit intoapache:mainfrom
cetra3 wants to merge 1 commit intoapache:mainfrom
Conversation
224a532 to
d6d6ec2
Compare
Contributor
Author
|
OK adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #21066
Rationale for this change
The Unparser breaks in some certain scenarios, which also don't have test coverage.
What changes are included in this PR?
Are these changes tested?
Yes, they are tested, the majority of this PR is to introduce more test paths.
Are there any user-facing changes?
No breaking changes, but some SQL generated by the Unparser may end up being a little different