feat(stats): cap NDV at row count in statistics estimation#21081
Open
asolimando wants to merge 1 commit intoapache:mainfrom
Open
feat(stats): cap NDV at row count in statistics estimation#21081asolimando wants to merge 1 commit intoapache:mainfrom
asolimando wants to merge 1 commit intoapache:mainfrom
Conversation
6adef34 to
ddfd8f3
Compare
Member
Author
|
cc: @jonathanc-n |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
After a filter reduces a table from 100 to 10 rows, or a LIMIT 10 caps the output, the NDV (e.g. 80) should not exceed the new row count. Without capping, join cardinality estimation uses an inflated denominator, leading to inaccurate estimates.
What changes are included in this PR?
Cap
distinct_countatnum_rowsin three places to prevent NDV from exceeding the actual row count:max_distinct_countin join cardinality estimation (joins/utils.rs)collect_new_statisticsin filter output statistics (filter.rs)Statistics::with_fetch(stats.rs), which coversGlobalLimitExec,LocalLimitExec,SortExec(with fetch),CoalescePartitionsExec(with fetch), andCoalesceBatchesExec(with fetch)Note: NDV capping for
AggregateExecis covered separately in #20926.Are these changes tested?
test_filter_statistics_ndv_capped_at_row_count- verifies NDV capped at filtered row counttest_join_cardinalityexpected values for capped NDVtest_with_fetch_caps_ndv_at_row_count- verifies NDV capped after LIMITtest_with_fetch_ndv_below_row_count_unchanged- verifies NDV untouched when already below row countwith_fetchtests passAre there any user-facing changes?
No public API changes. Only internal statistics estimation is affected.
Disclaimer: I used AI to assist in the code generation, I have manually reviewed the output and it matches my intention and understanding.