fix(unparser): Fix BigQuery timestamp literal format in SQL unparsing#21103
Open
sgrebnov wants to merge 2 commits intoapache:mainfrom
Open
fix(unparser): Fix BigQuery timestamp literal format in SQL unparsing#21103sgrebnov wants to merge 2 commits intoapache:mainfrom
sgrebnov wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
The default
Dialect::timestamp_with_tz_to_stringusesdt.to_string()which produces timestamps with a space before the TimeZone offset. This causes filter pushdown to fail when unparsing timestamp predicates for BigQuery.BigQuery rejects this format. Per the BigQuery timestamp docs, the offset must be attached directly to the time:
What changes are included in this PR?
Following similar to DuckDB pattern/fix override
timestamp_with_tz_to_stringforBigQueryDialectto produce valid timestamp formatBefore (default
dt.to_string()):After (%:z format):
Are these changes tested?
Added unit test and manual e2e test with Google BigQuery instance.
Are there any user-facing changes?
No