Skip to content

fix[physical-plan/aggregates]: fix grouping by Ree<Dict>#21195

Merged
alamb merged 1 commit intoapache:mainfrom
polarsignals:asubiotto/groupreedict
Mar 27, 2026
Merged

fix[physical-plan/aggregates]: fix grouping by Ree<Dict>#21195
alamb merged 1 commit intoapache:mainfrom
polarsignals:asubiotto/groupreedict

Conversation

@asubiotto
Copy link
Copy Markdown
Contributor

There was a match arm missing, so the inner dictionary was not reconstructed, resulting in a schema mismatch downstream.

Which issue does this PR close?

Rationale for this change

Fix a bug

What changes are included in this PR?

Match arm + memtable test verifying the fix

Are these changes tested?

Yes

Are there any user-facing changes?

Queries that would previously error now do not

@github-actions github-actions bot added core Core DataFusion crate physical-plan Changes to the physical-plan crate labels Mar 27, 2026
@asubiotto
Copy link
Copy Markdown
Contributor Author

cc @brancz @alamb

There was a match arm missing, so the inner dictionary was not reconstructed,
resulting in a schema mismatch downstream.

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
@asubiotto asubiotto force-pushed the asubiotto/groupreedict branch from c29d5fa to 768109d Compare March 27, 2026 10:17
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @asubiotto

@alamb alamb added this pull request to the merge queue Mar 27, 2026
Merged via the queue into apache:main with commit 0359a3c Mar 27, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GROUP BY on RunEndEncoded column with Dictionary values produces schema mismatch

2 participants