Add FileStreamBuilder for creating FileStreams#21261
Open
alamb wants to merge 8 commits intoapache:mainfrom
Open
Add FileStreamBuilder for creating FileStreams#21261alamb wants to merge 8 commits intoapache:mainfrom
FileStreamBuilder for creating FileStreams#21261alamb wants to merge 8 commits intoapache:mainfrom
Conversation
github-actions
bot
added
core
alamb
commented
Mar 31, 2026
| let mut stream = | ||
| FileStream::new(&scan_config, 0, opener, &ExecutionPlanMetricsSet::new())?; | ||
| let metrics = ExecutionPlanMetricsSet::new(); | ||
| let mut stream = FileStreamBuilder::new(&scan_config) |
Contributor
Author
There was a problem hiding this comment.
this illustrates the new API pretty well -- instead of a pile of arguments to FileStream::new there is now FileStreamBuilder
| let file_stream = | ||
| FileStream::new(&config, 0, Arc::new(self.opener), &metrics_set) | ||
| .unwrap() | ||
| .with_on_error(on_error); |
Contributor
Author
There was a problem hiding this comment.
FileStream was already starting to grow a builder interface as it gained features, so let's just make it directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
@Dandandan and I are in the process of significantly reworking how FileStream works internally (morsels!)
To support this, I want to get the code ready for a reorganization and minimize the diffs
What changes are included in this PR?
FileStreamBuilderAre these changes tested?
Yes by existing CI.
Are there any user-facing changes?
Certain user facing API code that uses FileStream will need to use
FileStreamBuilderrather than directly construct aFileStream