chore: Add array_slice tests for overlapping nulls across inputs#21540
Merged
mbutrovich merged 1 commit intoapache:mainfrom Apr 10, 2026
Merged
Conversation
Pin the NullBuffer::union semantics introduced in apache#21482 by testing rows where multiple inputs (array, from, to, stride) are simultaneously null.
Contributor
Author
|
cc @metegenez |
mbutrovich
approved these changes
Apr 10, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks for following up with the extra tests, @neilconway!
Contributor
|
Thanks for the effort @neilconway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per reviewer comment in #21482, this adds a test case for
array_slicefor various situations in which multiple inputs (array, from, to, stride) are simultaneously null.