refactor: Introduce SpillState enum for memory-limited NLJ execution#21636
Open
viirya wants to merge 1 commit intoapache:mainfrom
Open
refactor: Introduce SpillState enum for memory-limited NLJ execution#21636viirya wants to merge 1 commit intoapache:mainfrom
viirya wants to merge 1 commit intoapache:mainfrom
Conversation
viirya
force-pushed
the
nlj-memory-limited-state-enum
branch
from
70862ee to
3a906a8
Compare
Replace scattered Option fields and boolean flags with a dedicated SpillState enum that explicitly tracks the fallback state: - Disabled: fallback not possible (unsupported join type or no disk) - Pending: fallback possible, holding left_plan and task_context for re-execution on OOM - Active: fallback triggered, holding all spill-related state (left_stream, reservation, spill_manager, etc.) This makes the state transitions explicit and eliminates the implicit is_memory_limited() check based on Option::is_some(). Co-authored-by: Claude Code
viirya
force-pushed
the
nlj-memory-limited-state-enum
branch
from
3a906a8 to
dabe6dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The current approach does use Option fields as implicit state flags (e.g., left_stream.is_some() to check if we're in memory-limited mode), which is fragile. This introduces a dedicated enum to make the execution state explicit.
What changes are included in this PR?
Replace scattered Option fields and boolean flags with a dedicated SpillState enum that explicitly tracks the fallback state:
This makes the state transitions explicit and eliminates the implicit is_memory_limited() check based on Option::is_some().
Co-authored-by: Claude Code
Are these changes tested?
Existing tests
Are there any user-facing changes?
No