chore(deps): update tokio from 1.51 to 1.52#21670
Merged
gabotechs merged 1 commit intoapache:mainfrom Apr 16, 2026
Merged
Conversation
gabotechs
reviewed
Apr 16, 2026
| tempfile = "3" | ||
| testcontainers-modules = { version = "0.15" } | ||
| tokio = { version = "1.51", features = ["macros", "rt", "sync"] } | ||
| tokio = { version = "1.52", features = ["macros", "rt", "sync"] } |
Contributor
There was a problem hiding this comment.
This should be fine 👍, but just want to double check something first:
The tokio = "1.51" version declaration in DataFusion is already compatible with consumers having tokio = "1.52" on their project, meaning that you should be already able use tokio = "1.52" in your codebase depending on DataFusion without this PR. In other words, having tokio = "1.51" here is like DataFusion saying to the outside world "I support tokio 1.X as long as X >= 51"
Did you find any issues with that that require bumping the minimum supported version here?
Contributor
Author
There was a problem hiding this comment.
Agreed, no issues at all. This is just an anticipation to keep the fork aligned with upstream.
Contributor
There was a problem hiding this comment.
I did some digging, and it seems that Dependabot is configured in this project with a very aggressive minimum minor supported version for dependencies.
Actually, tokio itself was just bumped last week in https://github.com/apache/datafusion/pull/21435/changes#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542L195-R195.
While this is not the configuration I'd recommend for a project, it's what we have today in DataFusion, so this PR should be good to go 👍
gabotechs
approved these changes
Apr 16, 2026
Contributor
gabotechs
left a comment
gabotechs
left a comment
There was a problem hiding this comment.
As discussed in https://github.com/apache/datafusion/pull/21670/changes#r3092179794, this is good to go. Thanks @ahmed-mez!
Contributor
|
run benchmarks |
Contributor
|
Also tokio-rs/tokio#7757 seems it might be significant for us |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing ahmed/bump-tokio (c41fd81) to a0dbbab (merge-base) diff using: tpch File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing ahmed/bump-tokio (c41fd81) to a0dbbab (merge-base) diff using: tpcds File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing ahmed/bump-tokio (c41fd81) to a0dbbab (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Update tokio from 1.51 to 1.52
Rationale for this change
Allow experimenting with a new setting
Builder::enable_eager_driver_handoffin tokio, among other improvements in the latest tokio version.What changes are included in this PR?
Tokio version update in Cargo.toml
Are these changes tested?
All existing tests pass
Are there any user-facing changes?
No