Improve ergonomics for ExecutionPlanMetricsSet and MetricsSet#21762
Merged
gabotechs merged 3 commits intoapache:mainfrom Apr 22, 2026
Merged
Improve ergonomics for ExecutionPlanMetricsSet and MetricsSet#21762gabotechs merged 3 commits intoapache:mainfrom
gabotechs merged 3 commits intoapache:mainfrom
Conversation
Contributor
Author
martin-g
reviewed
Apr 22, 2026
Contributor
Author
|
Thanks for the quick (and quality) review @martin-g! pushed some changes |
gabotechs
force-pushed
the
improve-metrics-set-ergonomics
branch
from
81e16b4 to
0905a39
Compare
martin-g
approved these changes
Apr 22, 2026
Contributor
Author
|
Thanks @martin-g for the quality review! |
gabotechs
added a commit
to DataDog/datafusion
that referenced
this pull request
Apr 22, 2026
…#21762) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - None ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Sometimes, when an `ExecutionPlan` implementation is complex, different metrics are collected from different structs that compose the whole execution plan. These metrics need to eventually be served from the single entrypoint `ExecutionPlan::metrics()` or `DataSource::metrics()`, and the current api does not have good methods for merging several `ExecutionPlanMetricsSet` coming from different sources into a single one. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Add some basic conversion and iteration methods for `MetricsSet` and `ExecutionPlanMetricsSet`, in order to improve ergonomics around these structs. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> This is purely just basic std trait implementations and method exposure, so as long as the code compiles, I don't think it needs further tests. ## Are there any user-facing changes? People will see some more available methods in the `MetricsSet` and `ExecutionPlanMetricsSet` structs for ergonomics. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> (cherry picked from commit ff844be)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Sometimes, when an
ExecutionPlanimplementation is complex, different metrics are collected from different structs that compose the whole execution plan.These metrics need to eventually be served from the single entrypoint
ExecutionPlan::metrics()orDataSource::metrics(), and the current api does not have good methods for merging severalExecutionPlanMetricsSetcoming from different sources into a single one.What changes are included in this PR?
Add some basic conversion and iteration methods for
MetricsSetandExecutionPlanMetricsSet, in order to improve ergonomics around these structs.Are these changes tested?
This is purely just basic std trait implementations and method exposure, so as long as the code compiles, I don't think it needs further tests.
Are there any user-facing changes?
People will see some more available methods in the
MetricsSetandExecutionPlanMetricsSetstructs for ergonomics.