fix: make_array returns wrong row count for null-array input#21842
Open
mpurins wants to merge 1 commit intoapache:mainfrom
Open
fix: make_array returns wrong row count for null-array input#21842mpurins wants to merge 1 commit intoapache:mainfrom
mpurins wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
Bot
added
core
Jefffrey
reviewed
Apr 25, 2026
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn make_array_null_typed_column_preserves_rows() -> Result<()> { |
Contributor
There was a problem hiding this comment.
Let's remove this test as the SLT one is sufficient
| use arrow::array::ListArray; | ||
|
|
||
| #[test] | ||
| fn make_array_inner_all_null_arrays_preserves_row_count_and_width() { |
Contributor
There was a problem hiding this comment.
Same for these unit tests
| } else { | ||
| // All-null inputs still need to flow through `array_array()` so rows | ||
| // are built per input row instead of collapsing to one value. | ||
| let data_type = arrays |
Contributor
There was a problem hiding this comment.
I feel we can get this from the return type, which is provided in the ScalarFunctionArgs in invoke_with_args, so we some plumbing we can reuse that instead of having this logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Noticed that spark array has the same issue and fixed that as well. Only now there are two almost identical
make_array_innerfunctions and I'm not sure if those should be unified or not.Are these changes tested?
Are there any user-facing changes?