build: allow posting comments on PRs made from forks and fix missing protobuf#21913
Merged
rluvaton merged 5 commits intoapache:mainfrom Apr 30, 2026
Merged
Conversation
github-actions
Bot
added
the
development-process
rluvaton
commented
Apr 29, 2026
| # delete) the existing comment instead of stacking new ones. | ||
| - name: Upsert sticky comment | ||
| if: steps.read.outputs.result != 'success' | ||
| uses: actions-cool/maintain-one-comment@909842216bc8e8658364c572ec52100f4c2cc50a # v3.3.0 |
Member
Author
There was a problem hiding this comment.
rluvaton
changed the title
Member
Author
|
@Jefffrey Can you please review? |
rluvaton
changed the title
Contributor
|
I'm not so sure about this level of complexity now, with needing to communicate between two workflows via uploading an artifact 🤔 Maybe we should revert the previous PR in the meantime while we get more eyes on this |
martin-g
reviewed
Apr 30, 2026
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The breaking-change detector added in #21499 fails on fork PRs with HTTP 403:
A read-only token can't post the sticky comment, so the workflow errors out at the
gh api … POST /commentscall.We can't switch to
pull_request_targeteither - ASF infra policy forbids it for any workflow exposingGITHUB_TOKEN(https://infra.apache.org/github-actions-policy.html), andcargo-semver-checkscompiles fork-controlled code (build.rs, proc macros) anyway, so granting it a write token would be unsafe.What changes are included in this PR?
Split the comment posting into a companion
workflow_runworkflow:breaking_changes_detector.ymlkeeps thepull_requesttrigger but only stages the result (pr_number,result,logs) and uploads it as an artifact. No write token, no comment posting from this workflow.breaking_changes_detector_comment.ymltriggers onworkflow_run, runs in the base-repo context withpull-requests: write, downloads the artifact, validates the inputs, and upserts/deletes the sticky comment viaactions-cool/maintain-one-comment. Never checks out PR code.The comment workflow uses a runtime-randomized heredoc delimiter when piping the fork-controlled logs into
$GITHUB_OUTPUT, to stop log content from closing the heredoc early and overwriting the validatedresultoutput (or injecting other keys).Drops the now-unused
commentsubcommand fromci/scripts/changed_crates.sh.also installed protobuf as noticed this failed when building subtrait in:
Are these changes tested?
No, cant really test it
Are there any user-facing changes?
No