Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .asf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ github:
- "Check Markdown Links"
- "Validate required_status_checks in .asf.yaml"
- "Spell Check with Typos"
- "Circular Dependency Check"
- "Detect Unused Dependencies"
# needs to be updated as part of the release process
# .asf.yaml doesn't support wildcard branch protection rules, only exact branch names
# https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#branch-protection
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/dependencies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,7 @@ on:
push:
branches-ignore:
- 'gh-readonly-queue/**'
paths:
- "**/Cargo.toml"
- "**/Cargo.lock"
pull_request:
paths:
- "**/Cargo.toml"
- "**/Cargo.lock"
Comment on lines -28 to -34
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if action is required it has to be run always

merge_group:
# manual trigger
# https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
Expand All @@ -42,7 +36,7 @@ permissions:

jobs:
depcheck:
name: circular dependency check
name: Circular Dependency Check
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly, if this PR is merged, every other PR will have to pull latest main in order to be merged..

Copy link
Copy Markdown
Contributor

@alamb alamb Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is ok -- we can merge to main and then add to the merge queue and then it will get merged eventually

runs-on: ubuntu-latest
container:
image: amd64/rust
Expand All @@ -61,6 +55,7 @@ jobs:
cargo run

detect-unused-dependencies:
name: Detect Unused Dependencies
runs-on: ubuntu-latest
container:
image: amd64/rust
Expand Down
Loading