-
Notifications
You must be signed in to change notification settings - Fork 2.1k
dependencies check are now required to merge ci #21940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,13 +25,7 @@ on: | |
| push: | ||
| branches-ignore: | ||
| - 'gh-readonly-queue/**' | ||
| paths: | ||
| - "**/Cargo.toml" | ||
| - "**/Cargo.lock" | ||
| pull_request: | ||
| paths: | ||
| - "**/Cargo.toml" | ||
| - "**/Cargo.lock" | ||
| merge_group: | ||
| # manual trigger | ||
| # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow | ||
|
|
@@ -42,7 +36,7 @@ permissions: | |
|
|
||
| jobs: | ||
| depcheck: | ||
| name: circular dependency check | ||
| name: Circular Dependency Check | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sadly, if this PR is merged, every other PR will have to pull latest main in order to be merged..
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that is ok -- we can merge to main and then add to the merge queue and then it will get merged eventually |
||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: amd64/rust | ||
|
|
@@ -61,6 +55,7 @@ jobs: | |
| cargo run | ||
|
|
||
| detect-unused-dependencies: | ||
| name: Detect Unused Dependencies | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: amd64/rust | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if action is required it has to be run always